feat(integrations): Support Django 5.1#3207
Merged
Merged
Conversation
sentrivana
changed the title
cclauss
approved these changes
Jun 27, 2024
Contributor
There was a problem hiding this comment.
Sweet!! Thx.
Oh... The failing tests are https://docs.djangoproject.com/en/dev/releases/5.1/#miscellaneous -- Might need a skipif
The undocumented django.urls.converters.get_converter() function is removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3207 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 133 133
Lines 14290 14290
Branches 3004 3004
=======================================
Hits 11355 11355
Misses 2089 2089
Partials 846 846 |
Contributor
|
Something like: @pytest.mark.skipif(
django.VERSION >= (5, 1)
reason="django.urls.converters.get_converter() function was removed in Django v5.1",
)https://docs.djangoproject.com/en/dev/releases/5.1/#miscellaneous
|
Contributor
Author
cclauss
reviewed
Jul 3, 2024
cclauss
approved these changes
Jul 3, 2024
Co-authored-by: Christian Clauss <cclauss@me.com>
sentrivana
marked this pull request as ready for review
July 16, 2024 14:51
sentrivana
enabled auto-merge (squash)
July 16, 2024 14:52
This reverts commit d6b567f.
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
5.1b1get_converterin tests since this was removed:Also did some manual tests, stuff looks ok.
Closes #3208